Merged
Conversation
FrancescAlted
approved these changes
Feb 11, 2026
Member
FrancescAlted
left a comment
FrancescAlted
left a comment
There was a problem hiding this comment.
LGTM. I think this a good enough implementation for now. Just make sure that you add the two new entries (cumsum and cumprod) in the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cumulative_sum/prod for array api compliance #466.
Also change reduction convention to load chunks along reduction axis, rather than last axis (benchmarks suggest doesn't make much difference though).
Could also implement kahan summation maybe although doesn't seem to help precision, as the problem is in np.cumsum on the chunks (less accurate than np.sum).